fix: public asset urls being treated as paths

vitejs · Mar 15, 2023 · 8276a7e · 8276a7e
1 parent e23f690
commit 8276a7e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/packages/vite/src/node/plugins/html.ts b/packages/vite/src/node/plugins/html.ts
@@ -18,6 +18,7 @@ import {
  getHash,
  isDataUrl,
  isExternalUrl,
+ isUrl,
  normalizePath,
  processSrcSet,
 } from '../utils'
@@ -811,11 +812,13 @@ export function buildHtmlPlugin(config: ResolvedConfig): Plugin {
  })
 
  result = result.replace(publicAssetUrlRE, (_, fileHash) => {
- return normalizePath(
- toOutputPublicAssetFilePath(
- getPublicAssetFilename(fileHash, config)!,
- ),
+ const publicAssetPath = toOutputPublicAssetFilePath(
+ getPublicAssetFilename(fileHash, config)!,
  )
+
+ return isUrl(publicAssetPath)
+ ? publicAssetPath
+ : normalizePath(publicAssetPath)
  })
 
  if (chunk && canInlineEntry) {

diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -217,6 +217,15 @@ function testCaseInsensitiveFS() {
  return fs.existsSync(CLIENT_ENTRY.replace('client.mjs', 'cLiEnT.mjs'))
 }
 
+export function isUrl(path: string): boolean {
+ try {
+ new URL(path)
+ return true
+ } catch {
+ return false
+ }
+}
+
 export const isCaseInsensitiveFS = testCaseInsensitiveFS()
 
 export const isWindows = os.platform() === 'win32'