Build error when using json objects in define

[lsdsjy]

Describe the bug

I wrote a logical expression to call a function when some pre-defined constant is truthy:

// main.js
__CONST_OBJ__.SOME_FLAG && doSomething()

// vite.config.js
export default {
  define: {
    __CONST_OBJ__: {
      SOME_FLAG: false,  // the value may be derived from environment variables
    },
  },
};

And running vite build throws error: error during build: Error: Unexpected token.

I think it's because when JS parsers encounter a { at the beginning of a line, it will be treated as the beginning of new block, not an object. See this repl. So the temporary workaround is to make { not the first character of a line, e.g. wrap it inside parenthses(Boolean(__CONST_OBJ__.SOME_FLAG)).

If I understand correctly, a possible fix is to wrap the object expression in parentheses before replacing. Don't know if there are any other pitfalls.

Reproduction

https://stackblitz.com/edit/vitejs-vite-76jfpr?file=main.js,vite.config.js&terminal=dev

Steps to reproduce

Run npm install and yarn build

System Info

System:
    StackBlitz
  npmPackages:
    vite: ^3.2.3 => 3.2.3

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[luo3house]

Vite docs says config define is only a replacement, so you should define the whole expression to replace instead.

// vite.config.js
export default {
  define: {
    '__CONST_OBJ__.SOME_FLAG': false,
  }
}

[lsdsjy]

Vite docs says config define is only a replacement, so you should define the whole expression to replace instead.

According to the docs, the replacement expression can be JSON object. I don't think it's an invalid use case.

[sapphi-red]

This is fixed by #11151 in 5.0.0-beta.13.