Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hmr): deduplicate paths and join them with commas #10891

Merged
merged 1 commit into from
Nov 13, 2022
Merged

feat(hmr): deduplicate paths and join them with commas #10891

merged 1 commit into from
Nov 13, 2022

Conversation

ArnaudBarre
Copy link
Member

When updating a non component file imported in multiple components, the hmr update log become noisy, and very noisy when tailwind is involved.

Before:
Screenshot 2022-11-12 at 13 26 12

After:
Screenshot 2022-11-12 at 13 23 55

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea 👍🏼

@patak-dev patak-dev added p2-nice-to-have Not breaking anything but nice to have (priority) feat: hmr labels Nov 12, 2022
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@patak-dev patak-dev merged commit 967299a into vitejs:main Nov 13, 2022
@ArnaudBarre ArnaudBarre deleted the hmr-update-logs branch November 13, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: hmr p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants