Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throws error when plugin tries to resolve ID to external URL #11731

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

chenfan0
Copy link
Contributor

Fixes #11633

Description

Because the staticImportedUrls will be traversed and the transformRequest function will be called, which leads to an error

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@jeromehan
Copy link
Contributor

jeromehan commented Jan 18, 2023

Fixes #11633
@chenfan0

image

image

I think essentially Vite doesn't yet provide the ability to resolve ID to external URL, this PR does not solve the problem

@chenfan0
Copy link
Contributor Author

Fixes #11633
@chenfan0

image image

I think essentially Vite doesn't yet provide the ability to resolve ID to external URL, this PR does not solve the problem
image
I think this is because react is not optimized, causing problems with react referenced inside react-dom. If this exclude is removed, it can be executed normally.

@jeromehan
Copy link
Contributor

jeromehan commented Jan 19, 2023

I think this is because react is not optimized, causing problems with react referenced inside react-dom. If this exclude is removed, it can be executed normally.

Excluding React is to verify whether Vite has the ability to resolve ID to external URL

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 30, 2023
@patak-dev patak-dev enabled auto-merge (squash) March 30, 2023 20:00
@patak-dev patak-dev merged commit 49674b5 into vitejs:main Mar 30, 2023
@chenfan0 chenfan0 deleted the fix/resolve branch June 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadAndTransform throws error when plugin tries to resolve ID to external URL
4 participants