Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build for production: icon within noscript will not be relocated (index.html) #11735

Closed
7 tasks done
AHorak opened this issue Jan 18, 2023 · 0 comments · Fixed by #11764
Closed
7 tasks done

build for production: icon within noscript will not be relocated (index.html) #11735

AHorak opened this issue Jan 18, 2023 · 0 comments · Fixed by #11764
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@AHorak
Copy link

AHorak commented Jan 18, 2023

Describe the bug

As you can see there is one on the noscript and the other one outside.
The one outside will be "relocated" from src/assets/favicon.svg to /assets/favicon-c725382f.svg

See the snippet from index.html of my react application.

Before building for production:

<noscript>
        <div style="position: fixed; margin: 0px auto;  top: 50%; left: 50%; transform: translate(-50%, -50%); z-index: 30000000"; text-align: center">
            <img src="src/assets/favicon.svg" width="64" height="64" style="display:block; margin: 0px auto">
            <p><b>You need to enable JavaScript to run this app.</b></p>
        </div>
    </noscript>
    <img src="src/assets/favicon.svg" width="64" height="64" style="display:block; margin: 0px auto">

After:

<noscript>
        <div style="position: fixed; margin: 0px auto;  top: 50%; left: 50%; transform: translate(-50%, -50%); z-index: 30000000"; text-align: center">
            <img src="src/assets/favicon.svg" width="64" height="64" style="display:block; margin: 0px auto">
            <p><b>You need to enable JavaScript to run this app.</b></p>
        </div>
    </noscript>
    <img src="/assets/favicon-c725382f.svg" width="64" height="64" style="display:block; margin: 0px auto">

Reproduction

?

Steps to reproduce

add noscript to your index.html with one img inside.

yarn run build vite

System Info

Binaries:
    Node: 16.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 109.0.5414.75
    Edge: Spartan (44.19041.1266.0), Chromium (109.0.1518.55)
    Internet Explorer: 11.0.19041.1566

Used Package Manager

yarn

Logs

No response

Validations

@sapphi-red sapphi-red added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants