fix: ignore sideEffects for scripts imported from html #12786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10735
Description
It seems that adding
moduleSideEffects: false
to scripts imported from .HTML files pushes rollup to tree shake everything. Because"sideEffects": false
is set in the package.json of the app, we end up doing this for every file.This fix works for this reproduction: #10735 (comment)
I don't know if the fix should be more generic though. We could do this as a stop-gap if no one has a better idea here.
What is the purpose of this pull request?