fix: lightningcss fails with html-proxy #13776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug when using Lightning CSS with Vite Server and html-proxy
Additional context
The issue was originally found when attempting to use Storybook with + Vitejs 4.4 with the
lightningcss
optioins enabled.The shell app builds but when build the preview iframe it breaks with the error:
I would guess the problem is here: https:/vitejs/vite/blob/main/packages/vite/src/node/plugins/css.ts#L2176:L2181
When processing CSS from proxy the
filePath
is an empty string or a relative path without a filename so we fail the first condition and try to read the file from the file system.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).