Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glob): trigger HMR for glob in a package #14117

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

sapphi-red
Copy link
Member

Description

When a package contained import.meta.glob, adding a file within that glob didn't trigger HMR.

fixes #10616

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added has workaround p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Aug 16, 2023
@stackblitz
Copy link

stackblitz bot commented Aug 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red marked this pull request as ready for review August 16, 2023 08:09
Comment on lines 60 to +64
)
)
modules.push(...(server.moduleGraph.getModulesByFile(id) || []))
) {
const mod = server.moduleGraph.getModuleById(id)
if (mod) modules.push(mod)
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An id (e.g. package/foo/index.js?v=version) is set here and server.moduleGraph.getModulesByFile(id) was returning [].

server._importGlobMap.set(
id,

I guess it was wrong to use server.moduleGraph.getModuleById as the _importGlobMap uses an id instead of file.

Another way to fix this is to remove ?v=version before calling getModulesByFile or setting _importGlobMap.

@patak-dev patak-dev merged commit 86cbf69 into vitejs:main Aug 16, 2023
10 checks passed
@sapphi-red sapphi-red deleted the fix/glob-hmr-package branch August 16, 2023 14:57
@bluwy bluwy mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has workaround p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite must be restarted along with browser refresh to pick up new files using import.meta.glob
2 participants