feat(resolve)!: remove resolve.browserField
#14733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve.browserField
was introduced deprecated by default in #10071. The plan was to updateresolve.mainFields
to['browser', 'module', 'jsnext:main', 'jsnext']
which I did in this PR.This particular change can be breaking for tooling as some tools (e.g.
vite-plugin-svelte
) wants to add additionalmainFields
, and the only way to not remove the existing['module', 'jsnext:main', 'jsnext']
was to hardcode it:https:/sveltejs/vite-plugin-svelte/blob/b4b4fddf4d226856aa0f27fa4f32621dfb2938bf/packages/vite-plugin-svelte/src/utils/constants.js#L1
https:/sveltejs/vite-plugin-svelte/blob/b4b4fddf4d226856aa0f27fa4f32621dfb2938bf/packages/vite-plugin-svelte/src/utils/options.js#L359-L362
Additional context
Noticed this while working on #14723
What is the purpose of this pull request?