refactor(esbuild)!: remove esbuild 0.17 -> 0.18 compat #14804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed esbuild 0.17 to 0.18 compat code we added in Vite 4. I only saw this comment that we should remove this in Vite 5 just now 😬
experimentalDecorators
needs to be enabled if usedsupported
handling foruseDefineForClassFields
. I figured it's better to document what's happening and how they can fix it. I initially thought we could respectesbuild.compilerOptions.target
and overrideesbuild.target
if set, but I don't think it's worth breaking that now, nor a good default. This is also esbuild's behaviour.I added some documentation to explain what's going on.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).