Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): skip url replace for function calls #15544

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix(css): skip url replace for function calls #15544

merged 2 commits into from
Jan 10, 2024

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Jan 9, 2024 •
edited
Loading

Description

Closes #10473

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 9, 2024
@bluwy bluwy changed the title fix(css): sass failed to skip resolving function call in url() fix(css): skip url replace for function calls Jan 10, 2024
@bluwy bluwy merged commit 21a52e6 into vitejs:main Jan 10, 2024
12 checks passed
@smeng9 smeng9 deleted the fix-scss-url-function branch January 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vite-url-rewrite] messes up url(), when the url contains a single function call with Scss
3 participants
@smeng9 @patak-dev @bluwy