Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref #14420 (comment)
Avoid
parseRequest
function and use plain regex instead.Perf link too long that it doesn't work :( Here's another benchmark: https://jsperf.app/nikobo
In case that ever fails again, here's the benchmark code:
Details
The result is that the regex version is roughly 70% faster.
Additional context
I made individual commits removing the usage of
parseRequest
(note: I messed up the name in the 3rd commit)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).