Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable fs.cachedChecks for custom watch ignore patterns #15828

Merged

Conversation

patak-dev
Copy link
Member

Description

We're seeing issues with fs.cachedChecks in Vitest in playgrounds that build a SSR bundle to dist.

Vitest has a default ignore rule that is making files added to dist invisible to the new cache: https:/vitest-dev/vitest/blob/6f5b42b7a8e8a3c2ddb1c6876ea474553d686e28/packages/vitest/src/defaults.ts#L78

While we find a good way to work out these issues (it may be that the tests should be reworked, or that there is a way to support this in the fs cache), this PR disables the cache by default if there are custom rules.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

stackblitz bot commented Feb 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 7, 2024
@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 365c102: Open

suite result latest scheduled
analogjs success success
astro success success
histoire failure failure
ladle success success
laravel failure failure
marko success success
nuxt success success
nx failure failure
previewjs success success
qwik failure failure
rakkas success success
remix failure failure
sveltekit success success
unocss success success
vike success success
vite-plugin-pwa success success
vite-plugin-react success failure
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success failure
vite-setup-catalogue success success
vitepress failure failure
vitest success success

@patak-dev patak-dev merged commit 9070be3 into main Feb 7, 2024
15 checks passed
@patak-dev patak-dev deleted the fix/disable-fs-cached-checks-for-custom-watch-ignore branch February 7, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants