Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): same src file request same key #8059

Merged
merged 6 commits into from
May 11, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented May 7, 2022

Description

fix: #8048

Additional context

If tag had scoped it need to generate new file content, else just need to use the same keys.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho added plugin: vue regression The issue only appears after a new release labels May 7, 2022
@patak-dev
Copy link
Member

patak-dev commented May 8, 2022

@poyoho @sapphi-red I think this PR and #7989 would interfere with each other. Probably better to first merge this one as it is a regression. @sapphi-red would you check if we should change something here to be compatible with yours?

@poyoho
Copy link
Member Author

poyoho commented May 8, 2022

IIUC,@sapphi-red need to make scoped=${descriptor.id} when the css compile with scoped. So the filename change can get a new css scoped. I think after this merged, #7989 need to move (template, style block) scoped=true to scoped=${descriptor.id}, and other is no scoped support.

@sapphi-red
Copy link
Member

@poyoho is correctly describing what I need to do. I think there is no change needed here to make it compatible with #7989.

@patak-dev patak-dev merged commit 4c54800 into vitejs:main May 11, 2022
@Szymon-dziewonski
Copy link

Szymon-dziewonski commented May 11, 2022

@patak-dev Thanks for fix, when it will be released?

@patak-dev
Copy link
Member

I think this is going to be in v3, we may release 3.0.0-beta.0 next week

@poyoho poyoho deleted the fix(vue)/same-file-src branch May 11, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vite/plugin-vue regression with css-module bundling
4 participants