Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): support at import preprocessed styles #8400

Merged
merged 12 commits into from
Jun 6, 2023

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented May 30, 2022

Description

fix: #8397
fix: #11837

Additional context

support css pre-processor lang for index.html


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added the p2-to-be-discussed Enhancement under consideration (priority) label May 30, 2022
@patak-dev
Copy link
Member

Interesting. Let's discuss this feature in the next team meeting.

@poyoho
Copy link
Member Author

poyoho commented Jun 1, 2022

I like this point #8397 (comment)

so I move

<style lang="scss">
@use "app"
</style>

to

<style>
@import url("./_app.scss")
</style>

@bluwy
Copy link
Member

bluwy commented Feb 26, 2023

We discussed this in the last meeting and agreed that this would be a nice feature to have. Digging more into this PR, it seems to do a different thing than the PR title.

It looks like this PR supports @import for scss/styl etc files which previously didn't work. I thought it was about supporting <style lang="sass"> in the html.

In either case, I think the former make sense and we could support it. I'll try to rebase the PR.

@bluwy bluwy changed the title feat: css preprocessor for index.html feat(css): support at import preprocessed styles Feb 26, 2023
@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) and removed p2-to-be-discussed Enhancement under consideration (priority) feat: html labels Feb 26, 2023
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Jun 6, 2023

📝 Ran ecosystem CI: Open

suite result
astro ❌ failure
histoire ❌ failure
iles ❌ failure
ladle ✅ success
laravel ✅ success
marko ❌ failure
nuxt ❌ failure
nx ✅ success
previewjs ✅ success
qwik ❌ failure
rakkas ❌ failure
sveltekit ✅ success
unocss ✅ success
vite-plugin-pwa ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success

@patak-dev
Copy link
Member

patak-dev commented Jun 6, 2023

re-checking qwik

vite-plugin-ssr, nuxt, marko, astro
we're already failing yesterday

histoire, iles, rakkas,
seems to fail in main today too
https://discord.com/channels/804011606160703521/928398470086291456/1115648870874099774

@patak-dev
Copy link
Member

/ecosystem-ci run qwik

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Jun 6, 2023

📝 Ran ecosystem CI: Open

suite result
qwik ✅ success

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Jun 6, 2023

📝 Ran ecosystem CI: Open

suite result
qwik ✅ success

@patak-dev patak-dev merged commit 2bd6077 into vitejs:main Jun 6, 2023
@TheElegantCoding
Copy link

perfect my error was with qwik

@poyoho poyoho deleted the feat/css-preprocessor-support branch June 8, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

SCSS files are not compiled when being imported from CSS files Inlining CSS and JS in HTML does not work
4 participants