Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated optimized dep removed from module graph #8533

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

patak-dev
Copy link
Member

Description

Context: withastro/astro#3568 (comment)

@matthewp uncovered a race condition when an optimized dep is invalidated and removed from the module graph and an outdated request for it is still on-fly (this request should be discarded, a new one is being requested by the browser)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@matthewp
Copy link
Contributor

lgtm, and thanks!

@patak-dev
Copy link
Member Author

Merging, it was confirmed by the Astro team that this fixes the race condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants