Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(import-analysis): improve error for jsx to not be preserve in tsconfig #12018

Merged
merged 3 commits into from
Feb 22, 2023
Merged

fix(import-analysis): improve error for jsx to not be preserve in tsconfig #12018

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d5bede
chore: jsx cannot be preserve in tsconfig
SyMind Feb 10, 2023
56707b0
docs: fix suggestion [skip ci]
bluwy Feb 12, 2023
22504fd
Merge branch 'main' into pr/SyMind/12018
bluwy Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/vite/src/node/plugins/importAnalysis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,15 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
;[imports, exports] = parseImports(source)
} catch (e: any) {
const isVue = importer.endsWith('.vue')
const isJsx = importer.endsWith('.jsx') || importer.endsWith('.tsx')
const maybeJSX = !isVue && isJSRequest(importer)

const msg = isVue
? `Install @vitejs/plugin-vue to handle .vue files.`
: maybeJSX
? `If you are using JSX, make sure to name the file with the .jsx or .tsx extension.`
? isJsx
? `If you use tsconfig.json, make sure to not set jsx to preserve.`
: `If you are using JSX, make sure to name the file with the .jsx or .tsx extension.`
: `You may need to install appropriate plugins to handle the ${path.extname(
importer,
)} file format, or if it's an asset, add "**/*${path.extname(
Expand Down