perf: improve isFileReadable performance #12397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #6868 the
isFileReadable
was optimized to not usetry
+catch
for figuring out if file does not exist. In #10793 this improvement was reverted in favor of filesystem access checks. This PR combines both of these together.This change has huge impact in performance when large amount of filesystem reads are done. In vitest-dev/vitest#3006 there is a reproduction case linked which runs 2.7s faster with these changes. If you need assistance for setting up the reproduction case let me know.
Before:
The
captureLargerStackTrace
andhandleErrorFromBinding
are fromfs.accessSync
:After:
Additional context
There are existing tests which nicely cover all requirements:
vite/packages/vite/src/node/__tests__/utils.spec.ts
Lines 244 to 267 in a595b11
The cost of using
try
+catch
for checking file system is well explained here: https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-2/What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).