Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimizeDeps during build and external ids #13274

Merged
merged 1 commit into from
May 23, 2023

Conversation

patak-dev
Copy link
Member

Description

Follow up to #12851. playground/ssr-resolve was failing when using test-build-without-commonjs-plugin (forcing optimizing deps).

We should find a good way to test optimized deps during build for all playgrounds, maybe as part of ecosystem-ci. After this PR and #13273, all tests are green locally.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented May 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added p3-minor-bug An edge case that only affects very specific usage (priority) feat: deps optimizer Esbuild Dependencies Optimization labels May 19, 2023
@patak-dev patak-dev merged commit e3db771 into main May 23, 2023
@patak-dev patak-dev deleted the fix/optimized-deps-during-build-and-external-ids branch May 23, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: deps optimizer Esbuild Dependencies Optimization p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants