Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: skip computing sourceRoot in injectSourcesContent #15207

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

patak-dev
Copy link
Member

Description

injectSourcesContent is ~2% in vite-dev-server-perf

sourceRoot wasn't being used at all in this benchmark. We also discussed with @sapphi-red that the realpath call may be unneeded. We can explore removing that in another PR.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

stackblitz bot commented Dec 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the performance Performance related enhancement label Dec 1, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patak-dev patak-dev merged commit 1df1fd1 into main Dec 2, 2023
15 checks passed
@patak-dev patak-dev deleted the perf/skip-computing-source-root branch December 2, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants