Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only watch needed env files #15365

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: only watch needed env files #15365

merged 2 commits into from
Jan 10, 2024

Conversation

ArnaudBarre
Copy link
Member

ref: #15347

I wanted to create a test that would assert that page reload don't happen on editing (.env) in the env-nested playground, but asserting empty serverLogs is not really strong. Ideally we should be able to opt-in into debug logs on a test( suite) bases, but this would require re-loading Vite sources before each test and feels too much for such a small test

Copy link

stackblitz bot commented Dec 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Dec 22, 2023
patak-dev
patak-dev previously approved these changes Jan 8, 2024
@patak-dev patak-dev dismissed stale reviews from bluwy and themself via c8c39a1 January 8, 2024 17:31
@bluwy bluwy merged commit 476e572 into main Jan 10, 2024
9 of 10 checks passed
@bluwy bluwy deleted the arnaud/better-watch-env branch January 10, 2024 07:11
patak-dev added a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants