fix: deadlock in tsconfck for circles in references and extends #15932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@dominikg is reporting a 4x slow down for the typescript repo, so probably better to wait a bit more here. Leaving this PR as a draft as an option that was evaluated for now. |
patak-dev
added
the
p3-minor-bug
7 tasks
|
Closing as #16124 is merged (released in 5.1.6). |
patak-dev
deleted the
fix/deadlock-in-tsconfck-for-circles-in-references-and-extends
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply dominikg/tsconfck#161 as a patch. We discussed with @dominikg and it isn't clear what is the best forward. Getting this patch in Vite core will give tsconfck more time to decide how to deal with these circles.
We may see a small regression in performance, but it shouldn't affect most users.
Fixes vitest-dev/vitest#5182
Fixes Analog (reported by @brandonroberts)
Fixes #15870
Closes #15899
What is the purpose of this pull request?