feat: add environment::restart
#18353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
sapphi-red
commented
Oct 15, 2024
Comment on lines
+168
to
+169
| // TODO: when restart is called, close is not called for the previous environment | ||
| // that means depOptimizer is initialized but not closed |
There was a problem hiding this comment.
Would this be a problem? If we move the depOptimizer initialization to init, this won't be a problem. Is that safe to do?
There was a problem hiding this comment.
Maybe we should call await this.close() then extract things from the constructor and also call init(). There are some things missing to be re-inited. _crawlEndFinder should be recreated, moduleGraph too. I don't know if we should reuse things. We don't have any long term resource to keep.
sapphi-red
commented
Oct 16, 2024
| @@ -162,6 +166,21 @@ export class DevEnvironment extends BaseEnvironment { | |||
| ) | |||
| } | |||
|
|
|||
| // TODO: when restart is called, close is not called for the previous environment | |||
| // that means depOptimizer is initialized but not closed | |||
| async restart(options?: { watcher?: FSWatcher }): Promise<void> { | |||
There was a problem hiding this comment.
TODO: we should pass the new config here
|
Closing for now as we're trying #18263 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #18263
close #18264