Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase jest test timeout #3096

Closed
wants to merge 1 commit into from
Closed

test: increase jest test timeout #3096

wants to merge 1 commit into from

Conversation

patak-dev
Copy link
Member

Description

Testing CI after increasing jest test timeout from 30sec to 40sec. I also bumped the local timeout since in my Windows machine is required for tests to pass, so this may be also affecting other contributors.

This is what it took to run test-serve

Test Suites: 28 passed, 28 total
Tests:       228 passed, 228 total
Snapshots:   18 passed, 18 total
Time:        27.369 s

and test-build

Test Suites: 25 passed, 25 total
Tests:       200 passed, 200 total
Snapshots:   0 total
Time:        22.155 s

Additional context

There may be another issue to fix here, but the timeout is generating a lot of noise in CI at this point.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member Author

Closing, this is no longer needed after #3097

@patak-dev patak-dev closed this Apr 22, 2021
@patak-dev
Copy link
Member Author

Reopening this PR. We are getting timeouts issues even after fixing the server close race. I think it makes sense to merge this one, while we continue to improve the test suite.

@Shinigami92
Copy link
Member

But this is a new failing test 👀

packages/playground/backend-integration/__tests__/backend-integration.spec.ts https:/vitejs/vite/pull/3081/checks?check_run_id=2414364393#step:11:27

image

@patak-dev
Copy link
Member Author

Yes, but it is failing because of the timeout, maybe because this new test already pushed the test suite to pass the limit.

@patak-dev
Copy link
Member Author

I think you are right @Shinigami92, I tried locally and I also see this error after increasing the timeout.

@nihalgonsalves
Copy link
Member

Can you try setting DEBUG=pw:api to try to narrow down why they are failing?

@patak-dev
Copy link
Member Author

I did but looks like it is an issue with the test itself, all other tests are working correctly. Closing this PR again, we should directly talk in #3081

@patak-dev patak-dev closed this Apr 23, 2021
@nihalgonsalves nihalgonsalves mentioned this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants