Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circular dependency hmr causes refresh crash #4589

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Aug 12, 2021

Description

fix #4587

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

@OneNail is it possible to add a test for this one?

@y1d7ng
Copy link
Contributor Author

y1d7ng commented Aug 26, 2021

@OneNail is it possible to add a test for this one?

I will add test later 😄

@patak-dev patak-dev merged commit 00d8c9b into vitejs:main Nov 25, 2021
@sapphi-red sapphi-red mentioned this pull request Jul 3, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React HMR circular dependency crash
5 participants