fix(build): let top-level this
refer to globalThis
#5312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents
THIS_IS_UNDEFINED
warning from Rollup when@babel/plugin-transform-react-jsx
emitsjsx
calls that passthis
inside an arrow function component, which in turn leads toSOURCEMAP_ERROR
warnings, because thethis
reference doesn't exist in the original code.An example Rollup warning message for
SOURCEMAP_ERROR
:How code output is changed
This PR is especially important for
@vitejs/plugin-react
.…becomes…
Workaround
Ignore the warning, or set
rollupOptions.onwarn
to handle it manually.What is the purpose of this pull request?