Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update node version note #6177

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 19, 2021

Description

Fixes #6166. Also mention that templates may require a higher node version than v12 to work

Additional context

I'm not sure why Vite used to bump the required version from 12.0.0 to 12.2.0. It's technically a breaking change, but otherwise I've updated the docs to reflect that as well.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Dec 19, 2021
@patak-dev patak-dev merged commit 10e8f85 into vitejs:main Dec 19, 2021
@bluwy bluwy deleted the docs-node-version branch December 19, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed
3 participants