Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugin-legacy): remove regenerator-runtime note #8007

Merged

Conversation

sapphi-red
Copy link
Member

Description

This note was added by #3389 for #3362.

But regenerator-runtime was included without using additionalLegacyPolyfills with [email protected] + [email protected].
https://stackblitz.com/edit/vitejs-vite-wedvpk?file=package.json&terminal=dev
So I feel #3389 was something like #7819 (comment). (There was no reproduction so I cannot confirmed though)

Also regenerator-runtime is included without using additionalLegacyPolyfills with the latest version as reported by #7987.
I think this note should be removed.

fixes #7987

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label May 3, 2022
@patak-dev patak-dev merged commit 834efe9 into vitejs:main May 4, 2022
@sapphi-red sapphi-red deleted the docs/legacy-remove-ie11-regenerator branch May 4, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@vitejs/plugin-legacy] Why need regenerator-runtime when targeting IE11?
2 participants