feat: expose server resolved urls #8986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #8891
Expose
devServer.resolvedUrls
andpreviewServer.resolvedUrls
.This PR also removes a breaking change in Vite 3 where
printUrls
are async, now they are back as sync.Additional context
This mostly refactors on how we resolve urls and print them.
Previously,
printUrls
handle the entire resolve and print flow. Now, we break it into two parts. Whenever the server starts/restarts, we resolveresolvedUrls
. This usually happens in thelisten()
function which is async and we lend to avoidprintUrls
becoming async. Then,printUrls
become a basic function that only readsresolvedUrls
and prints it.Not sure how to add tests to this, but works locally for me and for vite-plugin-qrcode.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).