Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add appId in vitepress config #9099

Merged
merged 1 commit into from
Jul 14, 2022
Merged

docs: add appId in vitepress config #9099

merged 1 commit into from
Jul 14, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jul 14, 2022

Description

Screenshot 2022-07-14 at 10 58 13

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ydcjeff ydcjeff changed the title docs: add appId in vitepress config docs: add appId in vitepress config Jul 14, 2022
@netlify
Copy link

netlify bot commented Jul 14, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit ecdcab2
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cf9b1c658f610007c11b2e
😎 Deploy Preview https://deploy-preview-9099--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bluwy
Copy link
Member

bluwy commented Jul 14, 2022

Curious where you got the appId? 🤔

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jul 14, 2022

I searched on v2 docs and docsearch makes POST request to https://bh4d9od16a-dsn.algolia.net/1/indexes/*/queries?x-algolia-agent=Algolia for JavaScript (4.8.5); Browser (lite); docsearch (3.0.0-alpha.42); docsearch-react (3.0.0-alpha.42); docsearch.js (3.0.0-alpha.42)&x-algolia-api-key=b573aa848fd57fb47d693b531297403c&x-algolia-application-id=BH4D9OD16A. I take it from x-algolia-application-id.

@patak-dev patak-dev merged commit 8e0308b into vitejs:main Jul 14, 2022
@ydcjeff ydcjeff deleted the gh-9096 branch July 14, 2022 08:02
@patak-dev
Copy link
Member

Thanks @ydcjeff! Published and confirmed it works 👍🏼

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jul 14, 2022

@patak-dev Can you discuss with the admins who have access to algolia account?. Currently the search only shows migration from v1 when you search "migration". I think we need to update two separate apiKey for v2 and v3 docs.

Screenshot 2022-07-14 at 15 36 56

@patak-dev
Copy link
Member

Oh, interesting, @posva @kiaking do you know how this is handled in Vue for majors? Do we need to contact Algolia or is it something we can do on our side? I think we will need a new key for https://v2.vitejs.dev, ya.

@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Jul 15, 2022
@posva
Copy link
Contributor

posva commented Jul 19, 2022

@patak-dev yes, you need two applications and indexes since algolia needs to crawl two different websites. I think you need to contact algolia to get another index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Algolia Search is broken in docs
4 participants