-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resolve): make tryNodeResolve more robust #9170
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
165cdef
feat(resolve): support "fallback array" in package exports field
aleclarson 606f126
refactor: overrideConditions
aleclarson a94200f
fix: add `module` condition by default
aleclarson 296fe46
fix: config bundling regression
aleclarson 4d3c6ac
fix: respect `overrideConditions` and `isRequire`
aleclarson bb4fbd0
fix: try `resolveExports` call with postfix included
aleclarson f62843d
fix(resolve): make tryNodeResolve more robust
aleclarson 28c2587
test: unpackaged modules in node_modules
aleclarson 173ef76
fix: reset all resolvedPkg variables
aleclarson 5115d77
fix: bugs caught by tests
aleclarson fff33dc
fix: stop looking in node_modules once a workspace root is found
aleclarson 775ef0b
chore: fix lint
aleclarson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using
searchForWorkspaceRoot
, I added this function, which takes advantage of thepackageCache
. It also only checks the given directory, instead of an upward traversal.