Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to initialise optimizer without starting a server #4042

Closed
4 tasks done
sheremet-va opened this issue Aug 29, 2023 · 2 comments · Fixed by #4095
Closed
4 tasks done

Find a way to initialise optimizer without starting a server #4042

sheremet-va opened this issue Aug 29, 2023 · 2 comments · Fixed by #4095
Assignees
Labels
feat: optimizer Issues and PRs related to Vite optimizer

Comments

@sheremet-va
Copy link
Member

Clear and concise description of the problem

Currently, we call server.listen to initialize a web optimizer - unfortunately, this has many side effects (like starting a literal server) that we do not need and might cause a loss in performance.

Suggested solution

Investigate if it's possible to initialize optimizer without starting a Vite server.

Alternative

No response

Additional context

No response

Validations

@sheremet-va sheremet-va added the feat: optimizer Issues and PRs related to Vite optimizer label Aug 29, 2023
@sheremet-va sheremet-va self-assigned this Aug 29, 2023
@grigor-minasyan
Copy link

Just wanted to check what is the priority on this one, we ended up downgrading to 0.34.2 for the same reason, not sure why we need to start the server when testing, it also starts the server on the same port that the actual dev server is using, causing it to break the actual running server

@oldguan
Copy link

oldguan commented Sep 7, 2023

Just wanted to check what is the priority on this one, we ended up downgrading to 0.34.2 for the same reason, not sure why we need to start the server when testing, it also starts the server on the same port that the actual dev server is using, causing it to break the actual running server

remove "server.strictPort: true"
works for me

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: optimizer Issues and PRs related to Vite optimizer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants