Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): thresholds.autoUpdate to support mergeConfig #5818

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix(coverage): thresholds.autoUpdate to support mergeConfig #5818

merged 2 commits into from
Jun 3, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jun 2, 2024 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio force-pushed the fix/coverage-autothreshold-mergeconfig branch from 80dde1b to 45caed8 Compare June 2, 2024 15:15
@AriPerkkio AriPerkkio marked this pull request as ready for review June 2, 2024 15:19
@AriPerkkio AriPerkkio force-pushed the fix/coverage-autothreshold-mergeconfig branch from 45caed8 to b11948e Compare June 3, 2024 07:22
@AriPerkkio AriPerkkio force-pushed the fix/coverage-autothreshold-mergeconfig branch from b11948e to d1ef1b0 Compare June 3, 2024 07:23
@sheremet-va sheremet-va merged commit 7afb368 into vitest-dev:main Jun 3, 2024
15 of 16 checks passed
@AriPerkkio AriPerkkio deleted the fix/coverage-autothreshold-mergeconfig branch June 3, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to update coverage thresholds. Configuration file is too complex.
2 participants
@AriPerkkio @sheremet-va