Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): restore the original viewport when unselecting the preset viewport #5821

Merged

Conversation

sheremet-va
Copy link
Member

Description

This PR simplifies the resizing logic and fixes situations when clicking on the pre-defined viewports would reset the original iframe's viewport.

  1. Clicking on the viewport the second time will restore the original viewport
  2. Running a new test will reset the viewport button

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va changed the title fix(browser): restore the original viewport if no viewport UI buttons are used fix(browser): restore the original viewport when unselecting the preset viewport Jun 2, 2024
@sheremet-va sheremet-va merged commit 5ebb3ab into vitest-dev:main Jun 2, 2024
16 checks passed
@sheremet-va sheremet-va deleted the fix/browser-remember-viewport branch June 2, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant