Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Profiling Test Performance guide #6555

Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Sep 24, 2024

Description

Contains two separate commits. Should be merged without squash.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 33d7067
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66f813eea4e0d00008d0c73d
😎 Deploy Preview https://deploy-preview-6555--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/guide/profiling-test-performance.md Outdated Show resolved Hide resolved
docs/guide/profiling-test-performance.md Outdated Show resolved Hide resolved
docs/guide/profiling-test-performance.md Outdated Show resolved Hide resolved
@AriPerkkio AriPerkkio force-pushed the docs/profiling-test-performance branch 6 times, most recently from 39412fe to 1b72c3e Compare September 28, 2024 08:11
@AriPerkkio AriPerkkio marked this pull request as ready for review September 28, 2024 08:17
@AriPerkkio
Copy link
Member Author

This should be merged without squash to get fix(forks): --cpu-prof and --head-prof not working visible in changelogs as well.

hi-ogawa
hi-ogawa previously approved these changes Sep 28, 2024
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so comprehensive! I tested a profile example and it's very nice!

@AriPerkkio AriPerkkio force-pushed the docs/profiling-test-performance branch from 33d7067 to 95b001d Compare September 28, 2024 18:35
@AriPerkkio AriPerkkio force-pushed the docs/profiling-test-performance branch from 95b001d to 999502d Compare September 29, 2024 07:23
@sheremet-va
Copy link
Member

This looks awesome! Thank you!

@sheremet-va sheremet-va merged commit 1231189 into vitest-dev:main Sep 30, 2024
15 of 16 checks passed
@AriPerkkio AriPerkkio deleted the docs/profiling-test-performance branch September 30, 2024 15:59
@AriPerkkio
Copy link
Member Author

This should be merged without squash to get fix(forks): --cpu-prof and --head-prof not working visible in changelogs as well.

When release is done, let's manually add the fix commit in the changelogs. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants