fixes dotnet#3627 errors on reading host data are promoted to warning…

… level
vlada-shubina · Aug 16, 2021 · e7c11f2 · e7c11f2
1 parent 9d8b599
commit e7c11f2
Show file tree

Hide file tree

Showing 40 changed files with 424 additions and 10 deletions.
diff --git a/src/Microsoft.TemplateEngine.Cli/CliConsoleFormatter.cs b/src/Microsoft.TemplateEngine.Cli/CliConsoleFormatter.cs
@@ -99,7 +99,14 @@ private void WriteExceptionDetails<TState>(TextWriter textWriter, in LogEntry<TS
  {
  if (logEntry.Exception != null)
  {
- textWriter.WriteLine($"Details: {logEntry.Exception}");
+ if (logEntry.LogLevel == LogLevel.Debug || logEntry.LogLevel == LogLevel.Trace)
+ {
+ textWriter.WriteLine($"Details: {logEntry.Exception}");
+ }
+ else
+ {
+ textWriter.WriteLine($"Details: {logEntry.Exception.Message}");
+ }
  }
  }
  }

diff --git a/src/Microsoft.TemplateEngine.Cli/HostSpecificDataLoader.cs b/src/Microsoft.TemplateEngine.Cli/HostSpecificDataLoader.cs
@@ -43,8 +43,10 @@ private HostSpecificTemplateData ReadHostSpecificTemplateDataUncached(ITemplateI
  }
  catch (Exception e)
  {
- _engineEnvironment.Host.Logger.LogDebug(e, $"Failed to load host data for template {templateInfo.ShortNameList?[0] ?? templateInfo.Name}: the json data in {nameof(ITemplateInfoHostJsonCache.HostData)} is incorrect.");
- return HostSpecificTemplateData.Default;
+ _engineEnvironment.Host.Logger.LogWarning(
+ e,
+ LocalizableStrings.HostSpecificDataLoader_Warning_FailedToRead,
+ templateInfo.ShortNameList?[0] ?? templateInfo.Name);
  }
  }
 
@@ -70,8 +72,11 @@ private HostSpecificTemplateData ReadHostSpecificTemplateDataUncached(ITemplateI
  }
  catch (Exception e)
  {
- _engineEnvironment.Host.Logger.LogDebug(e, $"Failed to load host data for template {templateInfo.ShortNameList?[0] ?? templateInfo.Name}, file: " +
- $"{file?.GetDisplayPath() ?? templateInfo.MountPointUri + templateInfo.HostConfigPlace}");
+ _engineEnvironment.Host.Logger.LogWarning(
+ e,
+ LocalizableStrings.HostSpecificDataLoader_Warning_FailedToReadFromFile,
+ templateInfo.ShortNameList?[0] ?? templateInfo.Name,
+ file?.GetDisplayPath() ?? templateInfo.MountPointUri + templateInfo.HostConfigPlace);
  }
  finally
  {

diff --git a/src/Microsoft.TemplateEngine.Cli/LocalizableStrings.Designer.cs b/src/Microsoft.TemplateEngine.Cli/LocalizableStrings.Designer.cs
diff --git a/src/Microsoft.TemplateEngine.Cli/LocalizableStrings.resx b/src/Microsoft.TemplateEngine.Cli/LocalizableStrings.resx
@@ -761,4 +761,12 @@ The supported columns are: language, tags, author, type.</value>
  <value>Invalid command syntax: use '{0}' instead.</value>
  <comment>{0} - command syntax, example: dotnet new [PARTIAL_NAME] --list [FILTER_OPTIONS].</comment>
  </data>
-</root>
+ <data name="HostSpecificDataLoader_Warning_FailedToRead" xml:space="preserve">
+ <value>Failed to load dotnet CLI host data for template {0} from cache.</value>
+ <comment>{0} - template short name</comment>
+ </data>
+ <data name="HostSpecificDataLoader_Warning_FailedToReadFromFile" xml:space="preserve">
+ <value>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</value>
+ <comment>{0} - template short name, {1} - file path to host data.</comment>
+ </data>
+</root>
diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.cs.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.cs.xlf
@@ -515,6 +515,16 @@ Pokud si chcete zobrazit všechny aliasy, spusťte bez argumentů příkaz dotne
  <target state="translated">Příklady:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Nainstaluje zdroj nebo balíček šablon.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.de.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.de.xlf
@@ -515,6 +515,16 @@ Führen Sie "dotnet {1}--show-aliases" ohne Argumente aus, um alle Aliase anzuze
  <target state="translated">Beispiele:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Installiert ein Quell- oder Vorlagenpaket.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.es.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.es.xlf
@@ -515,6 +515,16 @@ Ejecute "dotnet {1} --show-aliases" sin argumentos para mostrar todos los alias.
  <target state="translated">Ejemplos:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Instala un paquete de origen o de plantilla.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.fr.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.fr.xlf
@@ -515,6 +515,16 @@ Exécutez « dotnet {1} --show-aliases » sans arguments pour afficher tous le
  <target state="translated">Exemples :</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Installe une source ou un package de modèle.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.it.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.it.xlf
@@ -515,6 +515,16 @@ Eseguire 'dotnet {1}--show-alias ' senza argomenti per mostrare tutti gli alias.
  <target state="translated">Esempi:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Installa un pacchetto di origine o di modello.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.ja.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.ja.xlf
@@ -515,6 +515,16 @@ Run 'dotnet {1} --show-aliases' with no args to show all aliases.</source>
  <target state="translated">例:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">ソースまたはテンプレート パッケージをインストールします。</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.ko.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.ko.xlf
@@ -515,6 +515,16 @@ Run 'dotnet {1} --show-aliases' with no args to show all aliases.</source>
  <target state="translated">예:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">소스 또는 템플릿 패키지를 설치합니다.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.pl.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.pl.xlf
@@ -515,6 +515,16 @@ Uruchom polecenie "dotnet {1}--show-aliases" bez argumentów, aby wyświetlić w
  <target state="translated">Przykłady:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Instaluje źródło lub pakiet szablonów.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.pt-BR.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.pt-BR.xlf
@@ -515,6 +515,16 @@ Execute 'dotnet {1} --mostrar- aliases' sem nenhum args para mostrar todos os al
  <target state="translated">Exemplos:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Instala um pacote de origem ou de modelo.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.ru.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.ru.xlf
@@ -515,6 +515,16 @@ Run 'dotnet {1} --show-aliases' with no args to show all aliases.</source>
  <target state="translated">Примеры:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Устанавливает источник или пакет шаблона.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.tr.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.tr.xlf
@@ -515,6 +515,16 @@ Tüm diğer adları göstermek için 'dotnet {1} --show-aliases' komutunu bağı
  <target state="translated">Örnekler:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">Bir kaynak veya şablon paketi yükler.</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.zh-Hans.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.zh-Hans.xlf
@@ -515,6 +515,16 @@ Run 'dotnet {1} --show-aliases' with no args to show all aliases.</source>
  <target state="translated">示例: </target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">安装源或模板包。</target>

diff --git a/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.zh-Hant.xlf b/src/Microsoft.TemplateEngine.Cli/xlf/LocalizableStrings.zh-Hant.xlf
@@ -515,6 +515,16 @@ Run 'dotnet {1} --show-aliases' with no args to show all aliases.</source>
  <target state="translated">範例:</target>
  <note />
  </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToRead">
+ <source>Failed to load dotnet CLI host data for template {0} from cache.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from cache.</target>
+ <note>{0} - template short name</note>
+ </trans-unit>
+ <trans-unit id="HostSpecificDataLoader_Warning_FailedToReadFromFile">
+ <source>Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</source>
+ <target state="new">Failed to load dotnet CLI host data for template {0} from {1}. The host data will be ignored.</target>
+ <note>{0} - template short name, {1} - file path to host data.</note>
+ </trans-unit>
  <trans-unit id="InstallHelp">
  <source>Installs a source or a template package.</source>
  <target state="translated">安裝來源或範本套件。</target>

diff --git a/src/Microsoft.TemplateEngine.Edge/LocalizableStrings.Designer.cs b/src/Microsoft.TemplateEngine.Edge/LocalizableStrings.Designer.cs
diff --git a/src/Microsoft.TemplateEngine.Edge/LocalizableStrings.resx b/src/Microsoft.TemplateEngine.Edge/LocalizableStrings.resx
@@ -228,6 +228,10 @@ Details: {0}.</value>
  <data name="TemplateCreator_TemplateCreationResult_Error_DestructiveChanges" xml:space="preserve">
  <value>Destructive changes detected.</value>
  </data>
+ <data name="TemplateInfo_Warning_FailedToReadHostData" xml:space="preserve">
+ <value>Failed to load host data in {0} at {1}.</value>
+ <comment>{0} - path to template location, {1} relative path inside template location.</comment>
+ </data>
  <data name="TemplatePackageManager_Error_FailedToScan" xml:space="preserve">
  <value>Failed to scan {0}.
 Details: {1}</value>