Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thirdparty/libbacktrace from libbacktrace project #22268

Open
lcheylus opened this issue Sep 21, 2024 · 2 comments
Open

Update thirdparty/libbacktrace from libbacktrace project #22268

lcheylus opened this issue Sep 21, 2024 · 2 comments
Labels
Bug This tag is applied to issues which reports bugs.

Comments

@lcheylus
Copy link
Contributor

lcheylus commented Sep 21, 2024

Describe the bug

Sources for thirdparty/libbacktrace have not been updated since May 2022 => PR #14277 by @nedpals

Master repository for libbacktrace have commits since this date of import in thirdparty => https:/ianlancetaylor/libbacktrace/

Reproduction Steps

  • Clone V sources from Git
  • git log thirdparty/libbacktrace

Expected Behavior

thirdparty/libbacktrace sources synced with https:/ianlancetaylor/libbacktrace/

Current Behavior

No issue with current version of thirdparty/libbacktrace

Possible Solution

  • Sync thirdparty/libbacktrace sources with https:/ianlancetaylor/libbacktrace/
  • Use "amalgamation" to merge libbacktrace sources in an unique file thirdparty/libbacktrace/base.c

Additional Information/Context

No response

V version

V 0.4.7 c866e37

Environment details (OS name and version, etc.)

V full version: V 0.4.7 c866e37
OS: openbsd, 7.6, GENERIC.MP#312
Processor: 2 cpus, 64bit, little endian

getwd: /home/fox/dev/vlang.git
vexe: /home/fox/dev/vlang.git/v
vexe mtime: 2024-09-20 08:44:43

vroot: OK, value: /home/fox/dev/vlang.git
VMODULES: OK, value: /home/fox/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.46.1
Git vroot status: weekly.2024.37-32-g7af312c5
.git/config present: true

CC version: OpenBSD clang version 16.0.6
thirdparty/tcc status: thirdparty-openbsd-amd64 8205cc59

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

@lcheylus lcheylus added the Bug This tag is applied to issues which reports bugs. label Sep 21, 2024
@lcheylus
Copy link
Contributor Author

lcheylus commented Sep 21, 2024

@nedpals You imported libbacktrace for Vlang in PR #14277 (May 2020). We would like to update it.

Please could you describe the process to create C sources for thirdparty/libbacktrace:

  • how to split code in darwin.c, linux.c and windows.c (included in backtrace.c)
  • how to use "amalgamation" to generate an unique base.c file from libbacktrace C sources

@nedpals
Copy link
Member

nedpals commented Sep 21, 2024

@lcheylus I honestly am not sure anymore how I did this as I have not worked on V nor any low-level work for more than a year now. Can't help with you that, I'm sorry.

@spaceface777 also helped in the process so he may be able to help you with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs.
Projects
None yet
Development

No branches or pull requests

2 participants