This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Hide manifests behind button toggle #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuessWhoSamFoo
force-pushed
the
manifest-button
branch
3 times, most recently
from
81a0406
to
383490a
Compare
xtreme-vikram-yadav
suggested changes
Sep 8, 2021
GuessWhoSamFoo
force-pushed
the
manifest-button
branch
from
383490a
to
9c1b4eb
Compare
Signed-off-by: Sam Foo <[email protected]>
GuessWhoSamFoo
force-pushed
the
manifest-button
branch
from
9c1b4eb
to
c9df909
Compare
xtreme-vikram-yadav
approved these changes
Sep 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
types.ImageSourceintroduces more complexity than desiredImageSourceafter usageWhich issue(s) this PR fixes
https://kubernetes.slack.com/archives/CM37M9FCG/p1630591265028400
Signed-off-by: Sam Foo [email protected]