Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Overflow selectors pattern #874

Merged

Conversation

nfarruggiagl
Copy link
Contributor

What this PR does / why we need it:
This is part of an old ticket. Adding Overflow Pattern to selectors.
Also fixes some lint issues.

Screen Shot 2020-04-23 at 15 55 18

Which issue(s) this PR fixes

  • Fixes #

Special notes for your reviewer:

Release note:

release-note

Signed-off-by: Nicolas Farruggia <[email protected]>
Copy link
Contributor

@mklanjsek mklanjsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked about this to Nico - we need selector/label tooltip now when we use ellipses. Without that, it's impossible to read the complete text of shortened selector/label.

@mklanjsek
Copy link
Contributor

Based on discussion with Nico, we will merge this for now and I’ll open a new issues about tooltips and see what can be done to work around Clarity limitations

@nfarruggiagl nfarruggiagl merged commit 7ea0fbe into vmware-archive:master Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants