-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datepicker disable partially works with reactive form #442
Comments
We prefer a working reproduction instead of a step-by-step instruction how to reproduce a bug, because this helps us try it and look for quick fixes at triage time. |
Quick reproduction is here. thanks. // app.module.ts
import { NgModule } from "@angular/core";
import { BrowserModule } from "@angular/platform-browser";
import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
import { ClarityModule } from "@clr/angular";
import { ReactiveFormsModule } from '@angular/forms'
import { AppComponent } from "./app.component";
@NgModule({
imports: [
BrowserModule,
BrowserAnimationsModule,
ClarityModule,
ReactiveFormsModule,
],
declarations: [ AppComponent ],
bootstrap: [ AppComponent ]
})
export class AppModule {} // app.components.ts
import { Component } from '@angular/core';
import { FormControl, FormGroup } from '@angular/forms'
@Component({
selector: 'app-root',
template: `
<form clrForm [formGroup]="dateForm" novalidate>
<h4>Reactive Form Demo</h4>
<clr-date-container>
<label>Date</label>
<input type="date" clrDate formControlName="date"/>
</clr-date-container>
</form>
`,
styleUrls: ['./app.component.scss']
})
export class AppComponent {
dateForm = new FormGroup({
date: new FormControl({ value: '', disabled: true })
});
} |
any news on this issue? It's very annoying that I have to disable the date input manually. |
The https:/vmware-clarity/ng-clarity/blob/main/projects/angular/src/forms/datepicker/date-input.ts#L118 |
Describe the bug
When disabled, calendar button works perfectly, but the input tag can change.
How to reproduce
dateForm = new FormGroup({ date: new FormControl({ value: '', disabled: true }) });
Expected behavior
Input must not be able to be modified as if calendar button does not work
Versions
Clarity version:
Framework version:
Angular 14.2
Device:
Additional notes
Disable can be accomplished by using [disabled] attribute directly inside input tag.
but it triggers a warning that
It looks like you're using the disabled attribute with a reactive form directive. ~~
The text was updated successfully, but these errors were encountered: