Schedule creation thru API triggers backup regardless of cron settings

[funkycode]

I think it's known issue as according to comment in code (

velero/pkg/controller/schedule_controller.go

Line 279 in e3d64d9

// get the latest run time (if the schedule hasn't run yet, this will be the zero value which will trigger

)

func getNextRunTime(schedule *api.Schedule, cronSchedule cron.Schedule, asOf time.Time) (bool, time.Time) {
    // get the latest run time (if the schedule hasn't run yet, this will be the zero value which will trigger
    // an immediate backup)
    var lastBackupTime time.Time
    if schedule.Status.LastBackup != nil {
        lastBackupTime = schedule.Status.LastBackup.Time
    }
    nextRunTime := cronSchedule.Next(lastBackupTime)

What steps did you take and what happened:
Here is the simple code to create scheduler we use
schedulerBuilder := builder.ForSchedule( c.context, name, ).CronSchedule(cronString).Template(backupBuilder.Result().Spec).ObjectMeta( builder.WithLabels(defaults.TufinReleaseVersionLabel, tosVersion)) scheduler, err = c.client.Schedules(c.context).Create(schedulerBuilder.Result())

What did you expect to happen:
One of the following:

1. Creation Date would be taken into account to calculate next run if schedule.Status.LastBackup.Time value is lower than creation date
2. LastBackup.Time value would be set to creation date if not specified on creation of object

[skriss]

xref #2433