Don't create a backup immediately after creating a schedule

changelogs/unreleased/4281-ywk253100

@@ -0,0 +1 @@
+Don't create a backup immediately after creating a schedule

pkg/controller/schedule_controller.go

@@ -276,11 +276,11 @@ func (c *scheduleController) submitBackupIfDue(item *api.Schedule, cronSchedule
 }
 
 func getNextRunTime(schedule *api.Schedule, cronSchedule cron.Schedule, asOf time.Time) (bool, time.Time) {
- // get the latest run time (if the schedule hasn't run yet, this will be the zero value which will trigger
- // an immediate backup)
  var lastBackupTime time.Time
  if schedule.Status.LastBackup != nil {
  lastBackupTime = schedule.Status.LastBackup.Time
+ } else {
+ lastBackupTime = schedule.CreationTimestamp.Time
  }
 
  nextRunTime := cronSchedule.Next(lastBackupTime)

pkg/controller/schedule_controller_test.go

@@ -274,7 +274,7 @@ func TestGetNextRunTime(t *testing.T) {
  {
  name: "first run",
  schedule: defaultSchedule(),
- expectedDue: true,
+ expectedDue: false,
  expectedNextRunTimeOffset: "5m",
  },
  {
@@ -319,18 +319,21 @@ func TestGetNextRunTime(t *testing.T) {
  require.NoError(t, err, "unable to parse test.lastRanOffset: %v", err)
 
  test.schedule.Status.LastBackup = &metav1.Time{Time: testClock.Now().Add(-offsetDuration)}
+ test.schedule.CreationTimestamp = *test.schedule.Status.LastBackup
+ } else {
+ test.schedule.CreationTimestamp = metav1.Time{Time: testClock.Now()}
  }
 
  nextRunTimeOffset, err := time.ParseDuration(test.expectedNextRunTimeOffset)
  if err != nil {
  panic(err)
  }
 
- // calculate expected next run time (if the schedule hasn't run yet, this
- // will be the zero value which will trigger an immediate backup)
  var baseTime time.Time
  if test.lastRanOffset != "" {
  baseTime = test.schedule.Status.LastBackup.Time
+ } else {
+ baseTime = test.schedule.CreationTimestamp.Time
  }
  expectedNextRunTime := baseTime.Add(nextRunTimeOffset)