Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about restoring when resource scaled to 0 #4911

Merged
merged 1 commit into from
May 25, 2022

Conversation

a-mccarthy
Copy link
Contributor

Signed-off-by: Abigail McCarthy [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

This adds a note that Velero will not restore using restic when a resource is scaled to 0 on a cluster. Also makes it clear that volumes to be restore with restic i identified with the backup.velero.io/backup-volumes annotation.

Does your change fix a particular issue?

Fixes #1919

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@a-mccarthy a-mccarthy added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4911 (8f31bff) into main (89907bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4911   +/-   ##
=======================================
  Coverage   41.69%   41.69%           
=======================================
  Files         204      204           
  Lines       18263    18263           
=======================================
  Hits         7615     7615           
  Misses      10069    10069           
  Partials      579      579           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89907bd...8f31bff. Read the comment docs.

@qiuming-best qiuming-best merged commit dfca4db into vmware-tanzu:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore using Restic into a deployment that been scaled down and PV/PVCs deleted hangs
4 participants