Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: update to 1.94.2 #51909

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

vscode: update to 1.94.2 #51909

wants to merge 1 commit into from

Conversation

atk
Copy link
Contributor

@atk atk commented Aug 19, 2024

Testing the changes

  • I tested the changes in this PR: briefly

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Aug 19, 2024

What about #51838 ?

@slymattz
Copy link
Contributor

slymattz commented Aug 21, 2024

FYI, about that failed x86_64-glibc build check, I just native-built the package on this arch and it turned out to be successful.

@atk atk changed the title vscode: update to 1.92.2 vscode: update to 1.93.0 Sep 9, 2024
@atk
Copy link
Contributor Author

atk commented Sep 17, 2024

The failure of the x64 build seems to stem from the process being killed after some time, not a failure with the build itself.

@loukamb
Copy link

loukamb commented Sep 19, 2024

I built this package myself as well and it built just fine. The automated builder just screws up, kills the process after an arbitrary delay and that prevents this package from being updated.

@atk
Copy link
Contributor Author

atk commented Oct 8, 2024

I'm currently attempting to update this to 1.94.0, but they removed yarn in favor of using npm, which causes a lot of issues with the way we build things.

@atk atk marked this pull request as draft October 10, 2024 20:25
@atk
Copy link
Contributor Author

atk commented Oct 10, 2024

There are still some issues, but I'm slowly getting there. The current version doesn't seem to run, as it expects are more recent node version. I guess we will need another electron update before this will work. @Johnnynator, any chance you could pick that up (since you did the last one)?

I've checked it. The required API is register from node:modules, which was introduced with node@20. The current electron version is 24, which still uses node@18.

@atk atk changed the title vscode: update to 1.93.0 vscode: update to 1.94.2 Oct 11, 2024
@Johnnynator
Copy link
Member

Yes, I can do some Electron updates, kinda skipped too many of them.
Have a build job for it running right now, but I kinda expect that the build will be partially broken and will require some fixups for musl.

@atk
Copy link
Contributor Author

atk commented Oct 12, 2024

This version also includes a fix for an RCE CVE: https://msrc.microsoft.com/update-guide/vulnerability/CVE-2024-43601, so I'd like to get it to the users asap.

@Johnnynator
Copy link
Member

As expected, have the same problem as we have with chromium right now, the v8 jit is broken on musl, need to either get that fixed or find a way to get jitless wasm (drumbrake) working in electron (electron 32 uses a chromium version that is one major version too old to have drumbrake included 😢 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants