Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librsvg: update to 2.59.1. #52498

Closed
wants to merge 1 commit into from
Closed

Conversation

icp1994
Copy link
Contributor

@icp1994 icp1994 commented Oct 4, 2024

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture: x86_64

I am not sure if this warrants rebuilding revdeps, hopefully someone can opine on that.

@icp1994
Copy link
Contributor Author

icp1994 commented Oct 4, 2024

If I'm reading the logs right, /usr/bin/cargo is not available in cross 🤔

@chrysos349
Copy link
Contributor

fix cross

if [ "$CROSS_BUILD" ]; then
	XBPS_CROSS_RUSTFLAGS+=" -L${XBPS_BUILDDIR}/${pkgname}-${version}/build/rsvg"
	configure_args="-Dtriplet=${XBPS_CROSS_RUST_TARGET}"
	post_patch() {
		vsed -i meson.build -e "s/not meson.is_cross_build() and //"
	}
fi

@icp1994
Copy link
Contributor Author

icp1994 commented Oct 11, 2024

Thanks, that worked.

@classabbyamp
Copy link
Member

missing dependency: 7e715df, caused build fails in ART

aadi58002 pushed a commit to aadi58002/void-packages that referenced this pull request Oct 13, 2024
@classabbyamp
Copy link
Member

also, it seems the pkgconfig file is missing cflags on cross. this broke ART and appstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants