Update #{self.prefix} to match yamllint rules #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamllint defaults to require-starting-space, this change will fix the preamble to match the yamllint rules so that inline linting doesn't throw errors while eyaml editing files. Signed-off-by: Jordan Conway <[email protected]>
|
I am not very familiar with this repo. Do we need tests for the change? |
Hopefully this will fix the issue with ruby 1.9.3 and travis tests thoughtbot/factory_bot#846 Signed-off-by: Jordan Conway <[email protected]>
|
I didn't notice any tests that needed to be done, I just pushed a travis fix as well that clears up the failed builds. (cucumber was passing locally for me). |
|
@jordanconway Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yamllint defaults to require-starting-space, this change will fix the
preamble to match the yamllint rules so that inline linting doesn't
throw errors while eyaml editing files.
Signed-off-by: Jordan Conway [email protected]