Upgrading trollop to optimist to remove deprecation warnings

[chadlyon]

This may break ruby <= 1.8 but I am unable to test this since I don't know how to set up a 1.8 env.

Fixes #267

[bastelfreak]

From my point of view this looks fine, but I would like to get feedback from another reviewer. Thanks for the contribution @chadlyon !

[tuxmea]

According to optimist website, ruby 1.8 is still OK. I assume we can remove the backwards-incompatible flag.

[chadlyon]

I tried to test in a 1.8 env and I got other incompatibilities:

Gem::InstallError: rake requires Ruby version >= 2.0.0.
An error occurred while installing rake (12.3.1), and Bundler cannot continue.
Make sure that `gem install rake -v '12.3.1'` succeeds before bundling.

In Gemfile:
  rake

...and then commenting out rake:

Gem::InstallError: ffi requires Ruby version >= 1.9.
An error occurred while installing ffi (1.9.25), and Bundler cannot continue.
Make sure that `gem install ffi -v '1.9.25'` succeeds before bundling.

In Gemfile:
  aruba was resolved to 0.6.2, which depends on
    childprocess was resolved to 0.9.0, which depends on
      ffi

...then I gave up. It seems that the test suite is incompatible with 1.8.

[tuxmea]

using gem "rake", '< 12' if RUBY_VERSION < '1.9' in Gemfile solves the rake issue.
But cucumber fails to start:

bundle exec cucumber -f progress
bundler: failed to load command: cucumber (/Users/mea/Documents/Work/github/voxpupuli/hiera-eyaml/vendor/ruby/1.8/bin/cucumber)
ArgumentError: wrong number of arguments (2 for 1)
  /Users/mea/Documents/Work/github/voxpupuli/hiera-eyaml/vendor/ruby/1.8/gems/json_pure-2.0.1/lib/json/common.rb:28:in `const_defined?'
  /Users/mea/Documents/Work/github/voxpupuli/hiera-eyaml/vendor/ruby/1.8/gems/json_pure-2.0.1/lib/json/common.rb:28:in `parser='
  /Users/mea/Documents/Work/github/voxpupuli/hiera-eyaml/vendor/ruby/1.8/gems/json_pure-2.0.1/lib/json/pure.rb:10

[ghoneycutt]

Do we care about ruby 1.8 from Puppet 3? This seems good to merge.

[bastelfreak]

Ruby 1.8 and Puppet 3 are EOL. We don't support it anymore.

[chadlyon]

When do you guys plan on cutting a release so that I can see these warning finally go away?

[franciscodelgadodev]

Any update about publishing this? Seems like the fix is already in place but it was never released to rubygems.