fix: upgrade to aruba-2/cucumber-8 #360
Conversation
|
|
||
| if public_key and public_key_env_var | ||
| warn 'both public_key and public_key_env_var specified, using public_key' | ||
| end | ||
|
|
||
| public_key_pem = if public_key_env_var and ENV[public_key_env_var] |
There was a problem hiding this comment.
the old line43-45 warning says the OPPOSITE thing to the old eval block.
Which one should be used? I chose to make the new behavior match the warning; but it's easy to flip.
There was a problem hiding this comment.
Better fix the warning and keep the current behavior so that existing setup with both which produce a broken warning but work now produce a genuine warning and still work as before.
There was a problem hiding this comment.
Refactored to have the warning match behavior but also remove the duplication of this load between the 3 key loads (encrypt public_key, decrypt public_key, decrypt private_key).
|
|
||
| if public_key and public_key_env_var | ||
| warn 'both public_key and public_key_env_var specified, using public_key' | ||
| end | ||
|
|
||
| public_key_pem = if public_key_env_var and ENV[public_key_env_var] |
There was a problem hiding this comment.
Better fix the warning and keep the current behavior so that existing setup with both which produce a broken warning but work now produce a genuine warning and still work as before.
Update tests and code to support aruba-2/cucumber-8 as needed by Ruby 3.2. Notably, HOME is treated specially, and environment variables are handled by the test suite. HOME is nominally a relative path, so take special precautions to work with an absolute path. Signed-off-by: Robin H. Johnson <[email protected]>
…ect code If both public_key and public_key_env_var were set, this message triggred: `both public_key and public_key_env_var specified, using public_key` However, the code actually preferred the `public_key_env_var` path. Change the warning to reflect that. Also change a similar line for private_key/private_key_env_var. Signed-off-by: Robin H. Johnson <[email protected]> Resolves: voxpupuli#360 (comment)
PKCS encrypt & decrypt had duplicate key loading logic with the same validations. Refactor to a single function to load PEM from variable or disk. Signed-off-by: Robin H. Johnson <[email protected]>
Signed-off-by: Robin H. Johnson <[email protected]> Resolves: voxpupuli#360 (comment)
|
Those new commits should cover all of the concerns |
|
@smortex can you please merge, I don't have permissions in your repo. |
Update tests and code to support aruba-2/cucumber-8 as needed by Ruby 3.2. Notably, HOME is treated specially, and environment variables are handled by the test suite. HOME is nominally a relative path, so take special precautions to work with an absolute path.
Signed-off-by: Robin H. Johnson [email protected]