Fix datatype of attribute metadata #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrolli
force-pushed
the
bugfix/metadata-wrong-type
branch
from
c8a7d8f
to
5d1824b
Compare
genebean
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
LGTM. I reviewed the template at templates/repo.conf.erb and this seems to match up to what is already in there.
Dan33l
requested changes
Dec 11, 2019
manifests/repo.pp
Outdated
| Optional[String[1]] $ncc_username = undef, | ||
| Optional[String[1]] $ncc_password = undef, | ||
| Hash[String, String] $urls = {}, | ||
| Variant[Enum['yum','apt','repomd','repoview'],Array[Enum['yum','apt','repomd','repoview']]] $metadata = 'repomd', |
There was a problem hiding this comment.
Like with bellow parameter update, it will be clearer to create a custom data type.
There was a problem hiding this comment.
@mrolli - are you game to do the adjustment mentioned here? If not I am happy to do it.
There was a problem hiding this comment.
@Dan33l Hope this is what you meant. Didn't squash by intention to make the addition of the new datatype explicit.
There was a problem hiding this comment.
I'm pretty sure it's what he had in mind. Merged! Thanks for the fix.
genebean
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
By adding datatypes in 4.1.0 the code now breaks as the attribute $metadata of class mrepo::repo actually does not only support a single string but also an array of strings. The strings are comprise of a set of keywords allowed to use.
This Pull Request (PR) fixes the following issues
n/a