Fix class containment #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mutters something about contain |
|
I would prefer not to leave Puppet < 3.4.0 unsupported just yet |
juniorsysadmin
force-pushed
the
fix-repo-deps
branch
from
5da2060
to
ed97240
Compare
I've changed my mind on this - the last commit use contain and therefore drops support for any Puppet version less than 3.4.0. If there are no objections on this I will squash the commits shortly. |
juniorsysadmin
force-pushed
the
fix-repo-deps
branch
from
ed97240
to
2ce80c8
Compare
|
Squashed and rebased |
|
Thanks @juniorsysadmin! Can you please rebase one more time to pick up the travis.yml updates from #127? Thanks! |
This patch uses contain and therefore removes support for Puppet versions below 3.4.0
juniorsysadmin
force-pushed
the
fix-repo-deps
branch
from
2ce80c8
to
6b849f2
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nodejs::repo::nodesourceclass includes a few classes that are not contained properly, meaning for instance that the NodeSource repository might be created after the Node.js package is installed when the distribution comes with a native Node.js package. This PR is an attempt to fix this without using inheritance, making some anchor readability changes as well. Failing RSpec test should already be fixed in #120 .